PATCH: mesh SCSI bus locks hard on 7500 when burning a CD-R in dao mode

On Sat, Feb 03, 2001 at 11:27:05AM -0500, Daniel Eisenbud [off-list ref] wrote:

On Sat, Feb 03, 2001 at 11:14:27AM -0500, Daniel Eisenbud [off-list ref] wrote:

quoted

On Sat, Feb 03, 2001 at 03:19:18PM +1100, Paul Mackerras [off-list ref] wrote:

[...]

quoted

quoted

Well, it could be declared in scsi.h but the actual table of values
should go in a .c file.

My current patch has a static function in the new file scsi_dataout.h,
which is included by all the drivers in question.   But I agree that it
would be cleaner to declare the function in scsi.h, change
scsi_dataout.h to scsi_dataout.c, make the function no longer static,
and tell make about the dependencies.  I'll do that.

The advantage of my current approach is that there are two SCSI drivers
(for acorn and i2o) that use copies of this table but that live outside
of drivers/scsi.  They already include scsi.h, and it's easy to make
them include scsi_dataout.h.  For the files inside drivers/scsi, it's
easy to see how to make them depend on scsi_dataout.o, but it's not
obvious to me how it should work for files that live elsewhere.  Am I
missing something obvious?

Here's the patch aginst the 2.4 bitkeeper tree.  The only hunk that
should fail against 2.2, though, is the include/scsi/scsi.h one, which
is trivial to fix.  Please let me know if it would be better either to
put the function I've addeed in a .c file instead, or to just change all
the different drivers' tables directly.

Meanwhile, I'll start trying to get a clue about the SCSI layer's abort
handling.

-Daniel

--
Daniel E. Eisenbud
eisenbud@cs.swarthmore.edu