Re: 2.4.0-test3

On Tue, 11 Jul 2000, Benjamin Herrenschmidt wrote:

quoted

Why is pmac_backlight.c compiled in for CONFIG_ALL_PPC?  Isn't it
PowerBook only thing?

Well, if you change that, then chipsfb.c, atyfb.c, aty128fb.c and via-
pmu.c must be changed too. It's not completely powerbook only since, at
term, this could driver also external LVDS LCD backlight.

Yes, that's true.  I forgot about that.  Sorry.  In any case, my initial
problem with this was just CONFIG_ADB_PMU thing, and I went too far.


Takashi Oe

--- linuxppc_2_3-vanilla/arch/ppc/kernel/pmac_backlight.c	Mon Jul 10 02:18:43 2000
+++ linuxppc_2_3-nubus/arch/ppc/kernel/pmac_backlight.c	Mon Jul 10 17:16:54 2000

@@ -63,7 +63,8 @@
 		if (backlight_level > BACKLIGHT_MAX)
 			backlight_level = BACKLIGHT_MAX;
 	}
-
+
+#ifdef CONFIG_ADB_PMU
 	backlight_autosave = machine_is_compatible("AAPL,3400/2400")
 		|| machine_is_compatible("AAPL,3500");
 	if (backlight_autosave) {

@@ -73,6 +74,7 @@
 			pmu_poll();
 		backlight_level = req.reply[1] >> 4;
 	}
+#endif /* CONFIG_ADB_PMU */

 	if (!backlighter->set_enable(1, backlight_level, data))
 		backlight_enabled = 1;

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/