Thread (2 messages) flat view 2 messages, 2 authors, 2000-06-11

PATCH: ncr885e PPC patch look ok to you?

From: Jeff Garzik <hidden>
Date: 2000-06-11 03:25:23

Does this patch, against 2.4.0-test1-ac13, look ok to you guys?

It includes the following changes for 2.3/2.4:

* Use init_etherdev's second argument to allocate automatically a
private structure for each board instance.  This eliminates some code
during board init

* do not loop on pci_find_device and then break out of the loop, because
we only support finding and initializing a single board

* use pci_enable_device to wake up device, and turn on PIO and MMIO
areas as necessary

* do not read base address registers and IRQ line directly from
hardware.  Read from struct pci_dev instead.  Use pci_resource_xxx where
appropriate to wrap direct pci-dev struct access.

* use pci_set_master to set busmastering and raise min latency, removing
code which did it "the manual way"

NOTE:  Maybe a PPC kernel expert can tell me whether pci_enable_device
on PPC actually enabled PIO/MMIO regions correctly?  If so, this patch
can, in addition to the change above, also remove the "manual" setting
of the PIO bit in PCI_COMMAND.

Regards,

	Jeff






--
Jeff Garzik              | Liberty is always dangerous, but
Building 1024            | it is the safest thing we have.
MandrakeSoft, Inc.       |      -- Harry Emerson Fosdick

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help