Thread (3 messages) flat view 3 messages, 3 authors, 2000-02-18

insw/outsw/insl/outsl (was: Re: your mail)

From: Geert Uytterhoeven <hidden>
Date: 2000-02-18 12:17:03

On Thu, 17 Feb 2000, Paul Mackerras wrote:
Does anyone have any objection if I make insw/outsw/insl/outsl *not*
byte-swap the data?  The reason is that these functions are mostly used
for transferring blocks of data, i.e. arrays of bytes.  I haven't found a
single instance where they are used for transferring arrays of 16 or
32-bit words.

This would mean that we wouldn't need the kludge in the ide stuff where we
redefine insw as ide_insw (which doesn't byte-swap).  There is currently a
bug there because insl does still byte-swap, which means that if you set
the -c1 flag with hdparm, you get byte-swapped data. :-(
Hmm... This is indeed ambiguous. Is e.g. insl() used to (a) read n 32-bit words
from (little endian) ISA I/O space, or (b) used to read n*4 bytes from ISA I/O
space, using 32-bit accesses?

What about moving this to linux-kernel? It affects all big endian platforms.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven ------------- Sony Software Development Center Europe (SDCE)
Geert.Uytterhoeven@sonycom.com ------------------- Sint-Stevens-Woluwestraat 55
Voice +32-2-7248638 Fax +32-2-7262686 ---------------- B-1130 Brussels, Belgium


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help