Thread (1 message) 1 message, 1 author, 1999-05-12

Re: PATCH: Fix 2 PPC/SYSV varargs problems

From: Jeffrey A Law <hidden>
Date: 1999-05-12 06:19:53

  In message [ref]you write:
  > --=====================_53744284==_
  > Content-Type: text/plain; charset="us-ascii"; format=flowed
  > 
  > Hi,
  > 
  > this patch is supposed to fix the following problems on PPC/SYSV:
  > 
  > 1. the varargs save area calculation bug, this is a hack and Richard ;-) 
  > probably won't like it, but maybe it's good enough for egcs-1.2
  > 
  > 2. if you call a function that uses more then 8 float args before all 
  > integer argument passing registers are consumed, egcs will missetup the 
  > calling sequence. I introduced a new variable cum->sysv_fwords in the 
  > CUMULATIVE_ARGS struct, which counts the saved float words and adjusted 
  > cum->words where needed (I hope). There maybe better/nicer ways to 
  > implement that, so tell me if you want a different solution. A testcase is 
  > attached, the original problem happens with gnuplot.
Has this problem been fixed?  I see patch from Richard which looks like it
is related:

       * va-ppc.h (__va_start_common): Let __builtin_saveregs do the work.
        * rs6000.c (expand_builtin_saveregs): For V4, initialize a private
        va_list struct, and return a pointer to it.
        (setup_incoming_varargs): V4 save area based off virtual_stack_vars
        instead of frame_pointer.

[ yes, I'm going through my backlog now trying to weed out issues that I
  don't need to deal with :-) ]

jeff

[[ This message was sent via the linuxppc-dev mailing list.  Replies are ]]
[[ not  forced  back  to the list, so be sure to Cc linuxppc-dev if your ]]
[[ reply is of general interest. Please check http://lists.linuxppc.org/ ]]
[[ and http://www.linuxppc.org/ for useful information before posting.   ]]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help