Thread (10 messages) 10 messages, 4 authors, 2021-12-21

Re: [PATCH] iomap: turn the byte variable in iomap_zero_iter into a ssize_t

From: Dan Williams <hidden>
Date: 2021-12-21 04:13:05
Also in: linux-fsdevel, nvdimm

On Mon, Dec 20, 2021 at 2:10 PM Matthew Wilcox [off-list ref] wrote:
Dan, why is this erroneous commit still in your tree?
iomap_write_end() cannot return an errno; if an error occurs, it
returns zero.  The code in iomap_zero_iter() should be:

                bytes = iomap_write_end(iter, pos, bytes, bytes, page);
                if (WARN_ON_ONCE(bytes == 0))
                        return -EIO;
Care to send a fixup? I'm away from my key at present, but can get it
pushed out later this week.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help