Re: [PATCH 3/6] pmem: pmem_dax_direct_access() to honor the DAXDEV_F_RECOVERY flag
From: Christoph Hellwig <hch@infradead.org>
Date: 2021-10-21 11:23:34
Also in:
dm-devel, linux-fsdevel, lkml, nvdimm
On Wed, Oct 20, 2021 at 06:10:56PM -0600, Jane Chu wrote:
- if (unlikely(is_bad_pmem(&pmem->bb, PFN_PHYS(pgoff) / 512, - PFN_PHYS(nr_pages)))) + if (unlikely(!(flags & DAXDEV_F_RECOVERY) && + is_bad_pmem(&pmem->bb, PFN_PHYS(pgoff) / 512, + PFN_PHYS(nr_pages))))
The indentation here is pretty messed up. Something like this would
be move normal:
if (unlikely(!(flags & DAXDEV_F_RECOVERY) &&
is_bad_pmem(&pmem->bb, PFN_PHYS(pgoff) / 512,
PFN_PHYS(nr_pages)))) {
but if we don't really need the unlikely we could do an actually
readable variant:
if (!(flags & DAXDEV_F_RECOVERY) &&
is_bad_pmem(&pmem->bb, PFN_PHYS(pgoff) / 512, PFN_PHYS(nr_pages)))