Re: [PATCH V2 4/5] libxfs: add kernel-compatible completion API
From: "Darrick J. Wong" <djwong@kernel.org>
Date: 2021-09-27 20:33:18
From: "Darrick J. Wong" <djwong@kernel.org>
Date: 2021-09-27 20:33:18
On Sat, Sep 25, 2021 at 03:59:00PM +0530, Chandan Babu R wrote:
On 25 Sep 2021 at 04:32, Eric Sandeen wrote:quoted
On 9/24/21 9:09 AM, Chandan Babu R wrote:quoted
From: Dave Chinner <redacted> This is needed for the kernel buffer cache conversion to be able to wait on IO synchrnously. It is implemented with pthread mutexes and conditional variables. Signed-off-by: Dave Chinner <redacted>I am inclined to not merge patches 4 or 5 until there's something that uses it. It can be merged and tested together with consumers, rather than adding unused code at this point. Thoughts?I think I will let Dave answer this question since I believe he most likely has a roadmap on when the consumers will land.
Technically speaking, one /could/ port xfs_scrub to use the kernel completion API instead of calling pthread APIs directly, but I don't see much gain from churning that. --D
-- chandan