Re: [PATCH 01/61] mkfs: move mkfs/proto.c declarations to mkfs/proto.h From: Christoph Hellwig <hch@infradead.org> Date: 2021-09-16 07:25:18 +extern char *setup_proto (char *fname); +extern void parse_proto (xfs_mount_t *mp, struct fsxattr *fsx, char **pp); +extern void res_failed (int err); It might be worth to drop the externs, the spaces before the opening braces and the xfs_mount_t typedef usage while you're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
Keyboard shortcuts hback out one level jnext message in thread kprevious message in thread ldrill in Escclose help / fold thread tree ?toggle this help