Re: [PATCH v2 10/15] xfs: disambiguate units for ftrace fields tagged "count"
From: Dave Chinner <david@fromorbit.com>
Date: 2021-08-19 05:38:18
On Wed, Aug 18, 2021 at 08:45:36PM -0700, Darrick J. Wong wrote:
From: Darrick J. Wong <djwong@kernel.org> Some of our tracepoints have a field known as "count". That name doesn't describe any units, which makes the fields not very useful. Rename the fields to capture units and ensure the format is hexadecimal when we're referring to blocks, extents, or IO operations. "fsbcount" are in units of fs blocks "bytecount" are in units of bytes "ireccount" are in units of inode records Signed-off-by: Darrick J. Wong <djwong@kernel.org> --- v2: rename the count units --- fs/xfs/xfs_trace.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
Looks good, though ireccount is not used anywhere... Reviewed-by: Dave Chinner <redacted> -- Dave Chinner david@fromorbit.com