On Fri, Aug 13, 2021 at 09:26:36AM -0700, Darrick J. Wong wrote:

On Fri, Aug 13, 2021 at 10:16:23AM +0200, Christoph Hellwig wrote:

quoted

With quotaoff not allowing disabling of accounting there is no need
for untagged lookups in this code, so remove the dead leftovers.

Repoted-by: Dan Carpenter [off-list ref]
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/xfs/xfs_icache.c | 39 ++++-----------------------------------
 1 file changed, 4 insertions(+), 35 deletions(-)

diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
index e7e69e55b7680a..f5a52ec084842d 100644
--- a/fs/xfs/xfs_icache.c
+++ b/fs/xfs/xfs_icache.c

@@ -43,15 +43,6 @@ enum xfs_icwalk_goal {

The patch itself looks fine, so
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

But you might as well convert the ag walk to use the foreach macros
like everywhere else:

True, this makes sense for consistency.  That being said, comparing the
two, I find the one without the extra layer of macro sugar way easier
to read.