Thread (32 messages) 32 messages, 2 authors, 2021-08-09

Re: [PATCH 10/14] xfs: flush inode inactivation work when compiling usage statistics

From: Dave Chinner <david@fromorbit.com>
Date: 2021-08-05 05:38:24

On Wed, Aug 04, 2021 at 07:07:17PM -0700, Darrick J. Wong wrote:
From: Darrick J. Wong <djwong@kernel.org>

Users have come to expect that the space accounting information in
statfs and getquota reports are fairly accurate.  Now that we inactivate
inodes from a background queue, these numbers can be thrown off by
whatever resources are singly-owned by the inodes in the queue.  Flush
the pending inactivations when userspace asks for a space usage report.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 fs/xfs/xfs_qm_syscalls.c |    8 ++++++++
 fs/xfs/xfs_super.c       |    3 +++
 2 files changed, 11 insertions(+)
Makes sense. These aren't perf/latency sensitive operations, so
waiting on completion of a flush shouldn't be a big deal.

Reviewed-by: Dave Chinner <redacted>
-- 
Dave Chinner
david@fromorbit.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help