Thread (7 messages) 7 messages, 3 authors, 2021-07-15

Re: [PATCH 2/2] xfs: fix an integer overflow error in xfs_growfs_rt

From: Dave Chinner <david@fromorbit.com>
Date: 2021-07-14 23:46:38

On Wed, Jul 14, 2021 at 02:25:28PM -0700, Darrick J. Wong wrote:
From: Darrick J. Wong <djwong@kernel.org>

During a realtime grow operation, we run a single transaction for each
rt bitmap block added to the filesystem.  This means that each step has
to be careful to increase sb_rblocks appropriately.

Fix the integer overflow error in this calculation that can happen when
the extent size is very large.  Found by running growfs to add a rt
volume to a filesystem formatted with a 1g rt extent size.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 fs/xfs/xfs_rtalloc.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Much easier to read now.

Reviewed-by: Dave Chinner <redacted>

-- 
Dave Chinner
david@fromorbit.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help