Thread (19 messages) 19 messages, 3 authors, 2021-07-18

Re: [PATCH 3/8] shared/298: fix random deletion when filenames contain spaces

From: Allison Henderson <hidden>
Date: 2021-07-09 23:39:16
Also in: fstests


On 7/6/21 5:21 PM, Darrick J. Wong wrote:
From: Darrick J. Wong <djwong@kernel.org>

Correct the deletion loop in this test to work properly when there are
files in $here that have spaces in their name.
Looks ok
Reviewed-by: Allison Henderson <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
  tests/shared/298 |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/shared/298 b/tests/shared/298
index 981a4dfc..bd52b6a0 100755
--- a/tests/shared/298
+++ b/tests/shared/298
@@ -163,7 +163,7 @@ get_holes $img_file > $fiemap_ref
  
  # Delete some files
  find $loop_mnt -type f -print | $AWK_PROG \
-	'BEGIN {srand()}; {if(rand() > 0.7) print $1;}' | xargs rm
+	'BEGIN {srand()}; {if(rand() > 0.7) printf("%s\0", $0);}' | xargs -0 rm
  echo "done."
  
  echo -n "Running fstrim..."
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help