On Fri, Jul 02, 2021 at 06:45:58PM +1000, Dave Chinner wrote:

On Fri, Jul 02, 2021 at 08:48:07AM +0100, Christoph Hellwig wrote:

quoted

quoted

@@ -366,7 +366,7 @@ xfs_log_writable(
 		return false;
 	if (xfs_readonly_buftarg(mp->m_log->l_targ))
 		return false;
-	if (XFS_FORCED_SHUTDOWN(mp))
+	if (xlog_is_shutdown(mp->m_log))

This wasn't XLOG_FORCED_SHUTDOWN to start with.  Same for a few more
spots.

Yup, but in the places where we are working on the log, we should be
checking the log state for shutdown, not the mount. They currently
mean the same thing, but that doesn't mean we should use mount based
checks in the log and vice versa.

Need documentation in the changelog, or even better a separate commit.