RE: [PATCH RFC 07/13] iomap: simplify iomap_swapfile_fail() with '%pD' specifier
From: Justin He <hidden>
Date: 2021-07-16 06:17:45
Also in:
linux-fsdevel, lkml
From: Justin He <hidden>
Date: 2021-07-16 06:17:45
Also in:
linux-fsdevel, lkml
Hi Christoph
-----Original Message----- From: Christoph Hellwig <hch@infradead.org> Sent: Friday, July 16, 2021 2:11 PM To: Justin He <redacted> Cc: linux-kernel@vger.kernel.org; Linus Torvalds <torvalds@linux- foundation.org>; Christoph Hellwig [off-list ref]; nd [off-list ref]; Darrick J. Wong [off-list ref]; linux-xfs@vger.kernel.org; linux- fsdevel@vger.kernel.org Subject: Re: [PATCH RFC 07/13] iomap: simplify iomap_swapfile_fail() with '%pD' specifier On Thu, Jul 15, 2021 at 11:15:27AM +0800, Jia He wrote:quoted
After the behavior of '%pD' is change to print the full path of file, iomap_swapfile_fail() can be simplified. Given the space with proper length would be allocated in vprintk_store(), the kmalloc() is not required any more. Besides, the previous number postfix of '%pD' in format string is pointless.This also touched iomap_dio_actor, but the commit og only mentions iomap_swapfile_fail.
Okay, I will refine the msg in next version. Thanks -- Cheers, Justin (Jia He)