Re: [PATCH 30/39] xfs: implement percpu cil space used calculation

On Wed, Jun 02, 2021 at 08:01:48PM -0700, Darrick J. Wong wrote:

On Thu, Jun 03, 2021 at 12:28:14PM +1000, Dave Chinner wrote:

quoted

On Wed, Jun 02, 2021 at 06:26:09PM -0700, Darrick J. Wong wrote:

quoted

So assuming that I grokked it all on the second try, maybe a comment is
in order for the aggregate function?

	/*
	 * We're in the middle of switching cil contexts.  Reset the
	 * counter we use to detect when the current context is nearing
	 * full.
	 */
	ctx->space_used = 0;

Hmmmm - I'm not sure where you are asking I put this comment...

Sorry, I meant the comment to be placed above the
"cilpcp->space_used = 0;" in the _aggregate function.

Ok. That'll cause rejects on all the subsequent patches so there's
not much point in posting just an update to this patch with that
done. I guess I'm sending out another 39 patches before the end of
the day.... :/

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com