Thread (11 messages) 11 messages, 3 authors, 2021-05-12

Re: [PATCH 2/2] xfs: remove dead stale buf unpin handling code

From: Brian Foster <hidden>
Date: 2021-05-12 14:30:09

On Wed, May 12, 2021 at 01:00:25PM +0100, Christoph Hellwig wrote:
quoted
+		ASSERT(list_empty(&lip->li_trans) && !bp->b_transp);
Nit:  Two separate ASSERTS are generally better than one with two
conditions and a "&&", so that when the assert triggers it shows which
condition caused it.
In this case both checks pretty much mean the same thing so I don't see
much added value, but I don't mind splitting it..

Brian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help