Re: [PATCH] xfs: fix xfs_reflink_unshare usage of filemap_write_and_wait_range
From: Chandan Babu R <hidden>
Date: 2021-04-29 07:28:28
On 29 Apr 2021 at 11:14, Darrick J. Wong wrote:
From: Darrick J. Wong <djwong@kernel.org> The final parameter of filemap_write_and_wait_range is the end of the range to flush, not the length of the range to flush.
Looks good to me. Reviewed-by: Chandan Babu R <redacted>
quoted hunk ↗ jump to hunk
Fixes: 46afb0628b86 ("xfs: only flush the unshared range in xfs_reflink_unshare") Signed-off-by: Darrick J. Wong <djwong@kernel.org> --- fs/xfs/xfs_reflink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index 4dd4af6ac2ef..060695d6d56a 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c@@ -1522,7 +1522,8 @@ xfs_reflink_unshare( if (error) goto out; - error = filemap_write_and_wait_range(inode->i_mapping, offset, len); + error = filemap_write_and_wait_range(inode->i_mapping, offset, + offset + len - 1); if (error) goto out;
-- chandan