Re: [PATCH 3/6] xfs: remove indirect calls from xfs_inode_walk{,_ag}

[PATCHSET v3 0/6] xfs: clean up incore inode walk functions · "Darrick J. Wong" <djwong@kernel.org> · 2021-03-26
[PATCH 3/6] xfs: remove indirect calls from xfs_inode_walk{,_ag} · "Darrick J. Wong" <djwong@kernel.org> · 2021-03-26
Re: [PATCH 3/6] xfs: remove indirect calls from xfs_inode_walk{,_ag} · Christoph Hellwig <hch@infradead.org> · 2021-03-26
[PATCH 1/6] xfs: use s_inodes in xfs_qm_dqrele_all_inodes · "Darrick J. Wong" <djwong@kernel.org> · 2021-03-26
Re: [PATCH 1/6] xfs: use s_inodes in xfs_qm_dqrele_all_inodes · Dave Chinner <david@fromorbit.com> · 2021-03-30
Re: [PATCH 1/6] xfs: use s_inodes in xfs_qm_dqrele_all_inodes · "Darrick J. Wong" <djwong@kernel.org> · 2021-03-30
Re: [PATCH 1/6] xfs: use s_inodes in xfs_qm_dqrele_all_inodes · Dave Chinner <david@fromorbit.com> · 2021-03-30
Re: [PATCH 1/6] xfs: use s_inodes in xfs_qm_dqrele_all_inodes · "Darrick J. Wong" <djwong@kernel.org> · 2021-03-30
Re: [PATCH 1/6] xfs: use s_inodes in xfs_qm_dqrele_all_inodes · Dave Chinner <david@fromorbit.com> · 2021-03-31
[PATCH 2/6] xfs: remove iter_flags parameter from xfs_inode_walk_* · "Darrick J. Wong" <djwong@kernel.org> · 2021-03-26
Re: [PATCH 2/6] xfs: remove iter_flags parameter from xfs_inode_walk_* · Christoph Hellwig <hch@infradead.org> · 2021-03-26
[PATCH 4/6] xfs: pass struct xfs_eofblocks to the inode scan callback · "Darrick J. Wong" <djwong@kernel.org> · 2021-03-26
Re: [PATCH 4/6] xfs: pass struct xfs_eofblocks to the inode scan callback · Christoph Hellwig <hch@infradead.org> · 2021-03-26
[PATCH 6/6] xfs: refactor per-AG inode tagging functions · "Darrick J. Wong" <djwong@kernel.org> · 2021-03-26
Re: [PATCH 6/6] xfs: refactor per-AG inode tagging functions · Christoph Hellwig <hch@infradead.org> · 2021-03-26
Re: [PATCH 6/6] xfs: refactor per-AG inode tagging functions · "Darrick J. Wong" <djwong@kernel.org> · 2021-03-26
[PATCH 5/6] xfs: merge xfs_reclaim_inodes_ag into xfs_inode_walk_ag · "Darrick J. Wong" <djwong@kernel.org> · 2021-03-26
Re: [PATCH 5/6] xfs: merge xfs_reclaim_inodes_ag into xfs_inode_walk_ag · Christoph Hellwig <hch@infradead.org> · 2021-03-26
Re: [PATCH 5/6] xfs: merge xfs_reclaim_inodes_ag into xfs_inode_walk_ag · "Darrick J. Wong" <djwong@kernel.org> · 2021-03-26

From: Christoph Hellwig <hch@infradead.org>
Date: 2021-03-26 06:09:59

+/* Forward declarations to reduce indirect calls */
+static int xfs_blockgc_scan_inode(struct xfs_inode *ip, void *args);

While we try to avoid forward declarations I don't think we really need
a comment justifying it.

Otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help