Thread (29 messages) 29 messages, 1 author, 2021-03-26
STALE1928d REVIEWED: 2 (0M)
Revisions (4)
  1. v8 [diff vs current]
  2. v9 [diff vs current]
  3. v11 [diff vs current]
  4. v16 current

[PATCH v16 13/28] xfsprogs: Remove duplicate assert statement in xfs_bmap_btalloc()

From: Allison Henderson <hidden>
Date: 2021-03-26 00:32:32
Subsystem: the rest · Maintainer: Linus Torvalds

From: Chandan Babu R <redacted>

Source kernel commit: aff4db57d510082f11194ca915d8101463c92d46

The check for verifying if the allocated extent is from an AG whose
index is greater than or equal to that of tp->t_firstblock is already
done a couple of statements earlier in the same function. Hence this

Reviewed-by: Allison Henderson <redacted>
Reviewed-by: Darrick J. Wong <redacted>
Signed-off-by: Chandan Babu R <redacted>
Signed-off-by: Darrick J. Wong <redacted>
Signed-off-by: Allison Henderson <redacted>
---
 libxfs/xfs_bmap.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/libxfs/xfs_bmap.c b/libxfs/xfs_bmap.c
index e9c9f45..836e5a5 100644
--- a/libxfs/xfs_bmap.c
+++ b/libxfs/xfs_bmap.c
@@ -3692,7 +3692,6 @@ xfs_bmap_btalloc(
 		ap->blkno = args.fsbno;
 		if (ap->tp->t_firstblock == NULLFSBLOCK)
 			ap->tp->t_firstblock = args.fsbno;
-		ASSERT(nullfb || fb_agno <= args.agno);
 		ap->length = args.len;
 		/*
 		 * If the extent size hint is active, we tried to round the
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help