Thread (8 messages) 8 messages, 3 authors, 2021-04-10

Re: [PATCH v3][next] xfs: Replace one-element arrays with flexible-array members

From: "Darrick J. Wong" <djwong@kernel.org>
Date: 2021-03-20 21:49:44
Also in: linux-hardening, lkml

On Sat, Mar 20, 2021 at 03:20:55PM -0500, Gustavo A. R. Silva wrote:

On 3/20/21 15:17, Darrick J. Wong wrote:
quoted
quoted
quoted
quoted
Below are the results of running xfstests for groups shutdown and log
with the following configuration in local.config:

export TEST_DEV=/dev/sda3
export TEST_DIR=/mnt/test
export SCRATCH_DEV=/dev/sda4
export SCRATCH_MNT=/mnt/scratch

The size for both partitions /dev/sda3 and /dev/sda4 is 25GB.
Looks good to me, will toss it at my fstests cloud and see if anything
shakes out.  Thanks for cleaning up this goofy thorn-pile!
Great. It's been fun to work on this. :p
Did you run the /entire/ fstests suite?  With this patch applied to
5.12-rc2, I keep seeing list corruption assertions about an hour into
Nope; I run xfstests 'shutdown' and 'log' groups on 5.11.0, only.

How do you run the entire fstests?
Could you give me some pointers?
./check -g all

(instead of "./check -g shutdown")
quoted
the test run, and usually on some test that heavily exercises allocating
and deleting file extents.  I'll try to look at this patch more closely
next week, but I figured I should let you know early, on the off chance
something sticks out to you.
OK. I'll go run my tests on 5.12-rc2.

Should I run the entire xfstests, too?
Yes, please.

--D
Thanks
--
Gustavo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help