Re: [PATCH 2/2] xfs: reduce ilock acquisitions in xfs_file_fsync

avoid taking the iolock in fsync unless actually needed v2 · Christoph Hellwig <hch@lst.de> · 2021-01-22
[PATCH 2/2] xfs: reduce ilock acquisitions in xfs_file_fsync · Christoph Hellwig <hch@lst.de> · 2021-01-22
Re: [PATCH 2/2] xfs: reduce ilock acquisitions in xfs_file_fsync · Dave Chinner <david@fromorbit.com> · 2021-01-22
Re: [PATCH 2/2] xfs: reduce ilock acquisitions in xfs_file_fsync · Christoph Hellwig <hch@lst.de> · 2021-01-23
Re: [PATCH 2/2] xfs: reduce ilock acquisitions in xfs_file_fsync · Christoph Hellwig <hch@lst.de> · 2021-01-26
Re: [PATCH 2/2] xfs: reduce ilock acquisitions in xfs_file_fsync · Brian Foster <hidden> · 2021-01-26
Re: [PATCH 2/2] xfs: reduce ilock acquisitions in xfs_file_fsync · Christoph Hellwig <hch@lst.de> · 2021-01-28
[PATCH 1/2] xfs: refactor xfs_file_fsync · Christoph Hellwig <hch@lst.de> · 2021-01-22
Re: [PATCH 1/2] xfs: refactor xfs_file_fsync · Dave Chinner <david@fromorbit.com> · 2021-01-22

From: Christoph Hellwig <hch@lst.de>
Date: 2021-01-28 08:03:14

On Mon, Jan 25, 2021 at 08:16:18AM -0500, Brian Foster wrote:

quoted

-	error = xfs_fsync_flush_log(ip, datasync, &log_flushed);
+	/*
+	 * Any inode that has dirty modifications in the log is pinned.  The
+	 * racy check here for a pinned inode while not catch modifications

s/while/will/ ?

Yes.  Darrick, can you fix this up when applying the patch, or do you
want me to resend?

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help