Re: [PATCH v2 7/9] xfs: remove duplicate wq cancel and log force from attr quiesce
From: Allison Henderson <hidden>
Date: 2021-01-22 03:14:09
On 1/21/21 8:45 AM, Brian Foster wrote:
These two calls are repeated at the beginning of xfs_log_quiesce(). Drop them from xfs_quiesce_attr(). Signed-off-by: Brian Foster <redacted> Reviewed-by: Darrick J. Wong <redacted>
Looks ok to me Reviewed-by: Allison Henderson <redacted>
quoted hunk ↗ jump to hunk
--- fs/xfs/xfs_super.c | 5 ----- 1 file changed, 5 deletions(-)diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 75ada867c665..8fc9044131fc 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c@@ -884,11 +884,6 @@ void xfs_quiesce_attr( struct xfs_mount *mp) { - cancel_delayed_work_sync(&mp->m_log->l_work); - - /* force the log to unpin objects from the now complete transactions */ - xfs_log_force(mp, XFS_LOG_SYNC); - xfs_log_clean(mp); }