Re: [PATCH 1/7] xfs: increase the default parallelism levels of pwork clients
From: "Darrick J. Wong" <djwong@kernel.org>
Date: 2021-01-18 19:58:30
From: "Darrick J. Wong" <djwong@kernel.org>
Date: 2021-01-18 19:58:30
On Mon, Jan 18, 2021 at 05:36:28PM +0000, Christoph Hellwig wrote:
On Thu, Jan 14, 2021 at 02:38:49PM -0800, Darrick J. Wong wrote:quoted
There already /is/ a pwork_threads sysctl knob for controlling quotacheck parallelism; and for the block gc workqueue I add WQ_SYSFS so that you can set /sys/bus/workqueue/devices/xfs-*/max_active.Hmm. A single know that is named to describe that it deals with the expected device parallelism might be easier to understand for users.
Where should I add a sysfs attributes for per-fs configuration knobs? I don't really want to add "expected parallelism" to /sys/fs/xfs/*/error because that seems like the wrong place, and /proc/sys/fs/xfs/ is too global for something that could depend on the device. --D