[PATCH v2 00/12] lazytime fix and cleanups · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
[PATCH v2 03/12] fs: only specify I_DIRTY_TIME when needed in generic_update_time() · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH v2 03/12] fs: only specify I_DIRTY_TIME when needed in generic_update_time() · Jan Kara <jack@suse.cz> · 2021-01-11
[PATCH v2 02/12] fs: correctly document the inode dirty flags · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH v2 02/12] fs: correctly document the inode dirty flags · Jan Kara <jack@suse.cz> · 2021-01-11
[PATCH v2 01/12] fs: fix lazytime expiration handling in __writeback_single_inode() · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH v2 01/12] fs: fix lazytime expiration handling in __writeback_single_inode() · Christoph Hellwig <hch@lst.de> · 2021-01-11
Re: [PATCH v2 01/12] fs: fix lazytime expiration handling in __writeback_single_inode() · Jan Kara <jack@suse.cz> · 2021-01-11
[PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time() · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time() · Christoph Hellwig <hch@lst.de> · 2021-01-11
Re: [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time() · Eric Biggers <ebiggers@kernel.org> · 2021-01-11
Re: [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time() · Dave Chinner <david@fromorbit.com> · 2021-01-12
Re: [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time() · Christoph Hellwig <hch@lst.de> · 2021-01-12
Re: [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time() · Jan Kara <jack@suse.cz> · 2021-01-11
[PATCH v2 10/12] gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync() · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH v2 10/12] gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync() · Jan Kara <jack@suse.cz> · 2021-01-11
[PATCH v2 11/12] ext4: simplify i_state checks in __ext4_update_other_inode_time() · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH v2 11/12] ext4: simplify i_state checks in __ext4_update_other_inode_time() · Christoph Hellwig <hch@lst.de> · 2021-01-11
Re: [PATCH v2 11/12] ext4: simplify i_state checks in __ext4_update_other_inode_time() · Eric Biggers <ebiggers@kernel.org> · 2021-01-11
Re: [PATCH v2 11/12] ext4: simplify i_state checks in __ext4_update_other_inode_time() · Christoph Hellwig <hch@lst.de> · 2021-01-12
Re: [PATCH v2 11/12] ext4: simplify i_state checks in __ext4_update_other_inode_time() · "Theodore Ts'o" <tytso@mit.edu> · 2021-02-03
Re: [PATCH v2 11/12] ext4: simplify i_state checks in __ext4_update_other_inode_time() · Jan Kara <jack@suse.cz> · 2021-01-11
[PATCH v2 08/12] fs: drop redundant check from __writeback_single_inode() · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH v2 08/12] fs: drop redundant check from __writeback_single_inode() · Christoph Hellwig <hch@lst.de> · 2021-01-11
Re: [PATCH v2 08/12] fs: drop redundant check from __writeback_single_inode() · Jan Kara <jack@suse.cz> · 2021-01-11
[PATCH v2 12/12] xfs: remove a stale comment from xfs_file_aio_write_checks() · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH v2 12/12] xfs: remove a stale comment from xfs_file_aio_write_checks() · "Darrick J. Wong" <djwong@kernel.org> · 2021-01-12
[PATCH v2 07/12] fs: clean up __mark_inode_dirty() a bit · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH v2 07/12] fs: clean up __mark_inode_dirty() a bit · Jan Kara <jack@suse.cz> · 2021-01-11
[PATCH v2 09/12] fs: improve comments for writeback_single_inode() · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH v2 09/12] fs: improve comments for writeback_single_inode() · Christoph Hellwig <hch@lst.de> · 2021-01-11
Re: [PATCH v2 09/12] fs: improve comments for writeback_single_inode() · Jan Kara <jack@suse.cz> · 2021-01-11
[PATCH v2 06/12] fs: pass only I_DIRTY_INODE flags to ->dirty_inode · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH v2 06/12] fs: pass only I_DIRTY_INODE flags to ->dirty_inode · Jan Kara <jack@suse.cz> · 2021-01-11
[PATCH v2 05/12] fs: don't call ->dirty_inode for lazytime timestamp updates · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH v2 05/12] fs: don't call ->dirty_inode for lazytime timestamp updates · Jan Kara <jack@suse.cz> · 2021-01-11
Re: [PATCH v2 00/12] lazytime fix and cleanups · Jan Kara <jack@suse.cz> · 2021-01-11
Re: [PATCH v2 00/12] lazytime fix and cleanups · Eric Biggers <ebiggers@kernel.org> · 2021-01-11
Re: [PATCH v2 00/12] lazytime fix and cleanups · "Theodore Ts'o" <tytso@mit.edu> · 2021-02-03
Re: [PATCH v2 00/12] lazytime fix and cleanups · Eric Biggers <ebiggers@kernel.org> · 2021-02-03
Re: [PATCH v2 00/12] lazytime fix and cleanups · "Theodore Ts'o" <tytso@mit.edu> · 2021-02-03

Re: [PATCH v2 08/12] fs: drop redundant check from __writeback_single_inode()

From: Christoph Hellwig <hch@lst.de>
Date: 2021-01-11 10:53:32
Also in: linux-ext4, linux-f2fs-devel, linux-fsdevel

On Fri, Jan 08, 2021 at 11:58:59PM -0800, Eric Biggers wrote:

From: Eric Biggers <redacted>

wbc->for_sync implies wbc->sync_mode == WB_SYNC_ALL, so there's no need
to check for both.  Just check for WB_SYNC_ALL.

Signed-off-by: Eric Biggers <redacted>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help