Re: [PATCH 04/11] vfs: add missing checks to copy_file_range

[PATCH 0/11] fs: fixes for major copy_file_range() issues · Dave Chinner <david@fromorbit.com> · 2018-12-03
[PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Amir Goldstein <amir73il@gmail.com> · 2018-12-03
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Christoph Hellwig <hch@infradead.org> · 2018-12-04
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Dave Chinner <david@fromorbit.com> · 2018-12-04
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Olga Kornievskaia <hidden> · 2018-12-04
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Dave Chinner <david@fromorbit.com> · 2018-12-04
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · J. Bruce Fields <hidden> · 2018-12-05
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Amir Goldstein <amir73il@gmail.com> · 2019-05-20
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Olga Kornievskaia <hidden> · 2019-05-20
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Amir Goldstein <amir73il@gmail.com> · 2019-05-20
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Olga Kornievskaia <hidden> · 2019-05-20
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Amir Goldstein <amir73il@gmail.com> · 2019-05-20
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Christoph Hellwig <hch@infradead.org> · 2018-12-05
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Dave Chinner <david@fromorbit.com> · 2018-12-05
Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail · Christoph Hellwig <hch@infradead.org> · 2018-12-05
[PATCH 02/11] vfs: introduce generic_copy_file_range() · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 02/11] vfs: introduce generic_copy_file_range() · Amir Goldstein <amir73il@gmail.com> · 2018-12-03
Re: [PATCH 02/11] vfs: introduce generic_copy_file_range() · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 02/11] vfs: introduce generic_copy_file_range() · Christoph Hellwig <hch@infradead.org> · 2018-12-04
[PATCH 03/11] vfs: no fallback for ->copy_file_range · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 03/11] vfs: no fallback for ->copy_file_range · Amir Goldstein <amir73il@gmail.com> · 2018-12-03
Re: [PATCH 03/11] vfs: no fallback for ->copy_file_range · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 03/11] vfs: no fallback for ->copy_file_range · Amir Goldstein <amir73il@gmail.com> · 2018-12-06
Re: [PATCH 03/11] vfs: no fallback for ->copy_file_range · Dave Chinner <david@fromorbit.com> · 2018-12-06
Re: [PATCH 03/11] vfs: no fallback for ->copy_file_range · Amir Goldstein <amir73il@gmail.com> · 2018-12-07
Re: [PATCH 03/11] vfs: no fallback for ->copy_file_range · Anna Schumaker <hidden> · 2018-12-03
Re: [PATCH 03/11] vfs: no fallback for ->copy_file_range · Christoph Hellwig <hch@infradead.org> · 2018-12-04
[PATCH 04/11] vfs: add missing checks to copy_file_range · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 04/11] vfs: add missing checks to copy_file_range · Amir Goldstein <amir73il@gmail.com> · 2018-12-03
Re: [PATCH 04/11] vfs: add missing checks to copy_file_range · Darrick J. Wong <hidden> · 2018-12-03
Re: [PATCH 04/11] vfs: add missing checks to copy_file_range · Olga Kornievskaia <hidden> · 2018-12-03
Re: [PATCH 04/11] vfs: add missing checks to copy_file_range · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 04/11] vfs: add missing checks to copy_file_range · Christoph Hellwig <hch@infradead.org> · 2018-12-04
[PATCH 06/11] vfs: copy_file_range needs to strip setuid bits · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 06/11] vfs: copy_file_range needs to strip setuid bits · Amir Goldstein <amir73il@gmail.com> · 2018-12-03
Re: [PATCH 06/11] vfs: copy_file_range needs to strip setuid bits · Christoph Hellwig <hch@infradead.org> · 2018-12-04
[PATCH 07/11] vfs: copy_file_range should update file timestamps · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 07/11] vfs: copy_file_range should update file timestamps · Amir Goldstein <amir73il@gmail.com> · 2018-12-03
Re: [PATCH 07/11] vfs: copy_file_range should update file timestamps · Olga Kornievskaia <hidden> · 2018-12-03
Re: [PATCH 07/11] vfs: copy_file_range should update file timestamps · Darrick J. Wong <hidden> · 2018-12-03
Re: [PATCH 07/11] vfs: copy_file_range should update file timestamps · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 07/11] vfs: copy_file_range should update file timestamps · Christoph Hellwig <hch@infradead.org> · 2018-12-04
[PATCH 08/11] vfs: push EXDEV check down into ->remap_file_range · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 08/11] vfs: push EXDEV check down into ->remap_file_range · Amir Goldstein <amir73il@gmail.com> · 2018-12-03
Re: [PATCH 08/11] vfs: push EXDEV check down into ->remap_file_range · Darrick J. Wong <hidden> · 2018-12-03
Re: [PATCH 08/11] vfs: push EXDEV check down into ->remap_file_range · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 08/11] vfs: push EXDEV check down into ->remap_file_range · Darrick J. Wong <hidden> · 2018-12-03
Re: [PATCH 08/11] vfs: push EXDEV check down into ->remap_file_range · Amir Goldstein <amir73il@gmail.com> · 2018-12-04
Re: [PATCH 08/11] vfs: push EXDEV check down into ->remap_file_range · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 08/11] vfs: push EXDEV check down into ->remap_file_range · Darrick J. Wong <hidden> · 2018-12-03
Re: [PATCH 08/11] vfs: push EXDEV check down into ->remap_file_range · Olga Kornievskaia <hidden> · 2018-12-04
[PATCH 11/11] ovl: allow cross-device copy_file_range calls · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 11/11] ovl: allow cross-device copy_file_range calls · Amir Goldstein <amir73il@gmail.com> · 2018-12-03
[PATCH 10/11] vfs: allow generic_copy_file_range to copy across devices · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 10/11] vfs: allow generic_copy_file_range to copy across devices · Amir Goldstein <amir73il@gmail.com> · 2018-12-03
[PATCH 05/11] vfs: use inode_permission in copy_file_range() · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 05/11] vfs: use inode_permission in copy_file_range() · Amir Goldstein <amir73il@gmail.com> · 2018-12-03
Re: [PATCH 05/11] vfs: use inode_permission in copy_file_range() · Darrick J. Wong <hidden> · 2018-12-03
Re: [PATCH 05/11] vfs: use inode_permission in copy_file_range() · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 05/11] vfs: use inode_permission in copy_file_range() · J. Bruce Fields <hidden> · 2018-12-05
Re: [PATCH 05/11] vfs: use inode_permission in copy_file_range() · Eric Biggers <ebiggers@kernel.org> · 2018-12-03
Re: [PATCH 05/11] vfs: use inode_permission in copy_file_range() · Christoph Hellwig <hch@infradead.org> · 2018-12-04
[PATCH 09/11] vfs: push copy_file_ranges -EXDEV checks down · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 09/11] vfs: push copy_file_ranges -EXDEV checks down · Amir Goldstein <amir73il@gmail.com> · 2018-12-03
Re: [PATCH 09/11] vfs: push copy_file_ranges -EXDEV checks down · Olga Kornievskaia <hidden> · 2018-12-03
Re: [PATCH 09/11] vfs: push copy_file_ranges -EXDEV checks down · Anna Schumaker <hidden> · 2018-12-03
Re: [PATCH 09/11] vfs: push copy_file_ranges -EXDEV checks down · Olga Kornievskaia <hidden> · 2018-12-03
Re: [PATCH 09/11] vfs: push copy_file_ranges -EXDEV checks down · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 09/11] vfs: push copy_file_ranges -EXDEV checks down · Christoph Hellwig <hch@infradead.org> · 2018-12-04
Re: [PATCH 09/11] vfs: push copy_file_ranges -EXDEV checks down · Dave Chinner <david@fromorbit.com> · 2018-12-04
Re: [PATCH 09/11] vfs: push copy_file_ranges -EXDEV checks down · Olga Kornievskaia <hidden> · 2018-12-04
Re: [PATCH 09/11] vfs: push copy_file_ranges -EXDEV checks down · Christoph Hellwig <hch@infradead.org> · 2018-12-05
Re: [PATCH 09/11] vfs: push copy_file_ranges -EXDEV checks down · Olga Kornievskaia <hidden> · 2018-12-05
[PATCH 12/11] man-pages: copy_file_range updates · Dave Chinner <david@fromorbit.com> · 2018-12-03
Re: [PATCH 12/11] man-pages: copy_file_range updates · Amir Goldstein <amir73il@gmail.com> · 2018-12-03
Re: [PATCH 12/11] man-pages: copy_file_range updates · Amir Goldstein <amir73il@gmail.com> · 2019-05-21

From: Amir Goldstein <amir73il@gmail.com>
Date: 2018-12-03 12:43:40
Also in: linux-fsdevel, linux-nfs, linux-unionfs

On Mon, Dec 3, 2018 at 10:34 AM Dave Chinner [off-list ref] wrote:

From: Dave Chinner <redacted>

Like the clone and dedupe interfaces we've recently fixed, the
copy_file_range() implementation is missing basic sanity, limits and
boundary condition tests on the parameters that are passed to it
from userspace. Create a new "generic_copy_file_checks()" function
modelled on the generic_remap_checks() function to provide this
missing functionality.

Signed-off-by: Dave Chinner <redacted>
---

Looks good.

Reviewed-by: Amir Goldstein <amir73il@gmail.com>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help