On Tue, Aug 21, 2018 at 09:22:04AM -0400, Brian Foster wrote:

On Mon, Aug 20, 2018 at 02:48:45PM +1000, Dave Chinner wrote:

quoted

From: Dave Chinner <redacted>

Replace m_flags feature checks with xfs_has_<feature>() calls and
rework the setup code to set flags in m_features.

Fallout is that there are some attr2/noattr2 changes - there's no
longer separate feature flags for the attr2 superblock and attr2
mount options - they both set the same flag. Hence we use the
noattr2 feature to trigger turning off attr2 at mount time - it
doesn't matter if it is the mount option or the sb feature that set
it, specifying noattr2 will turn off attr2 for the current mount and
clear it from the sb feature set.

[Discuss: Might be worth moving the attr2 changes into a separate
patch so it's clear what changes are being made.]

Yeah, a separate patch to condense the attr bits might be a good idea.

ok.

It also looks like some iosize feature changes crept in here that should
have been in a previous patch..?

No change, just a small reformats of the logic to use
common stacked if/else if/else rather than nested if/ternary
constructs. I can split it into another patch if you really want.

-Dave.
-- 
Dave Chinner
david@fromorbit.com