On Thu, Mar 15, 2018 at 10:46 AM, Darrick J. Wong
[off-list ref] wrote:

On Thu, Mar 15, 2018 at 06:38:39AM -0400, Brian Foster wrote:

quoted

On Wed, Mar 14, 2018 at 03:42:50PM -0500, Dave Chiluk wrote:

quoted

On Wed, Mar 14, 2018 at 1:12 PM, Darrick J. Wong
[off-list ref] wrote:

quoted

On Wed, Mar 14, 2018 at 01:17:24PM -0400, Brian Foster wrote:

...

quoted

Reviewed-by Dave Chiluk [off-list ref]

I'm also assuming this will get submitted back to the linux-stable
trees as the agfl packing change is already causing issues in the
stable trees.  If you do not intend to push it into the linux-stable
trees let me know and I'll take care of at least the major ones.

Yeah, I can cc stable in the next post along with the other minor fixes.
My question is how far back should this fix go? Was the plan to only go
back to v4.5 because that is where the packing fix first went in? Or
should this go back further because it looks like the packing fix was
backported to v3.10:

$ git show 96f859d52bcb1
commit 96f859d52bcb1c6ea6f3388d39862bf7143e2f30
Author: Darrick J. Wong [off-list ref]
Date:   Mon Jan 4 16:13:21 2016 +1100

    libxfs: pack the agfl header structure so XFS_AGFL_SIZE is correct

    ...

    cc: [off-list ref] # 3.10 - 4.4
    Signed-off-by: Darrick J. Wong [off-list ref]
    Reviewed-by: Dave Chinner [off-list ref]
    Signed-off-by: Dave Chinner [off-list ref]

Hmmm, I'm assuming that you'd want 3.10 at least for RHEL, but I'll let
you all figure that one out.

As far as the upstream kernels, 4.14.27, 4.9.87, 4.4.121, and 4.1.50
have that packing patch so I guess they'll all need some version of this.

--D

quoted

Brian

quoted

Thanks,
Dave
--

RHEL is actually fine for now, since they explicitly remove the
packing patch in their kernel, and xfsprogs.  Once you submit the
patches to linux-stable the ubuntu-kernel team monitors and includes
patches for the releases that they are stable maintainers of *(they
are downstream for 4.4 of gregkh, but currently maintain a 3.13, 4.13,
and 4.15 tree).

Also please add a Fixes line to your commit so it's obvious what patch
it helps remediate.  Fixes is actually not a great word here, but that
looks to be what the submitting-patches.txt doc calls for.

Fixes: 96f859d52bcb libxfs: pack the agfl header structure so
XFS_AGFL_SIZE is correct

This way stable maintainers understand that the fix resolves an issue
that was introduced by that patch, and can apply/not apply
appropriately.  Although in all honesty the patch really applies to
all stable kernels regardless of if the packing patch has been applied
or not.

Dave.