Re: [PATCH] xfs: use memset to initialize xfs_scrub_agfl_info
From: Darrick J. Wong <hidden>
Date: 2018-02-07 23:23:51
On Wed, Feb 07, 2018 at 04:23:38PM -0600, Eric Sandeen wrote:
Apparently different gcc versions have competing and incompatible notions of how to initialize at declaration, so just give up and fall back to the time-tested memset(). Signed-off-by: Eric Sandeen <redacted>
Looks ok, Reviewed-by: Darrick J. Wong <redacted>
quoted hunk ↗ jump to hunk
---diff --git a/fs/xfs/scrub/agheader.c b/fs/xfs/scrub/agheader.c index fd97552..05c66e0 100644 --- a/fs/xfs/scrub/agheader.c +++ b/fs/xfs/scrub/agheader.c@@ -767,7 +767,7 @@ struct xfs_scrub_agfl_info { xfs_scrub_agfl( struct xfs_scrub_context *sc) { - struct xfs_scrub_agfl_info sai = { 0 }; + struct xfs_scrub_agfl_info sai; struct xfs_agf *agf; xfs_agnumber_t agno; unsigned int agflcount;@@ -795,6 +795,7 @@ struct xfs_scrub_agfl_info { xfs_scrub_block_set_corrupt(sc, sc->sa.agf_bp); goto out; } + memset(&sai, 0, sizeof(sai)); sai.sz_entries = agflcount; sai.entries = kmem_zalloc(sizeof(xfs_agblock_t) * agflcount, KM_NOFS); if (!sai.entries) { --To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html