Re: [PATCH] xfs_scrub: don't ask user to run xfs_repair for only warnings
From: Bill O'Donnell <hidden>
Date: 2018-02-21 12:47:55
On Tue, Feb 20, 2018 at 07:36:54PM -0800, Darrick J. Wong wrote:
From: Darrick J. Wong <redacted> Don't advise the user to run xfs_repair on a filesystem that triggers warnings but no errors; there's no corruption for it to fix. Signed-off-by: Darrick J. Wong <redacted>
looks fine. Reviewed-by: Bill O'Donnell <redacted>
quoted hunk ↗ jump to hunk
--- scrub/xfs_scrub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c index ab26e63..53a105a 100644 --- a/scrub/xfs_scrub.c +++ b/scrub/xfs_scrub.c@@ -514,7 +514,7 @@ report_outcome( fprintf(stderr, _("%s: errors found: %llu; warnings found: %llu\n"), ctx->mntpoint, total_errors, ctx->warnings_found); - if (ctx->need_repair) + if (ctx->need_repair && total_errors > 0) fprintf(stderr, _("%s: Unmount and run xfs_repair.\n"), ctx->mntpoint); } --To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html