Re: [PATCH 2/4] xfs: skip xfs_check in _check_xfs_filesystem
From: Eryu Guan <hidden>
Date: 2018-02-08 12:51:55
Also in:
fstests
On Wed, Feb 07, 2018 at 01:19:31PM -0800, Darrick J. Wong wrote:
From: Darrick J. Wong <redacted> xfs_check has been long obsolete, so stop running it automatically after every test. Tests that explicitly want xfs_check can call it via _scratch_xfs_check or _xfs_check; that part doesn't go away. Signed-off-by: Darrick J. Wong <redacted>
I'd like to see an ACK on this from XFS community. Thanks, Eryu
quoted hunk ↗ jump to hunk
--- common/xfs | 17 ----------------- 1 file changed, 17 deletions(-)diff --git a/common/xfs b/common/xfs index 3dba40d..c63e5dc 100644 --- a/common/xfs +++ b/common/xfs@@ -386,23 +386,6 @@ _check_xfs_filesystem() ok=0 fi - # xfs_check runs out of memory on large files, so even providing the test - # option (-t) to avoid indexing the free space trees doesn't make it pass on - # large filesystems. Avoid it. - if [ "$LARGE_SCRATCH_DEV" != yes ]; then - _xfs_check $extra_log_options $device 2>&1 |\ - _fix_malloc >$tmp.fs_check - fi - if [ -s $tmp.fs_check ]; then - _log_err "_check_xfs_filesystem: filesystem on $device is inconsistent (c)" - echo "*** xfs_check output ***" >>$seqres.full - cat $tmp.fs_check >>$seqres.full - echo "*** end xfs_check output" >>$seqres.full - - xfs_metadump $device $seqres.check >>$seqres.full 2>&1 - ok=0 - fi - $XFS_REPAIR_PROG -n $extra_options $extra_log_options $extra_rt_options $device >$tmp.repair 2>&1 if [ $? -ne 0 ]; then _log_err "_check_xfs_filesystem: filesystem on $device is inconsistent (r)"