Thread (10 messages) 10 messages, 3 authors, 2018-02-05

Re: [PATCH 1/4] mkfs: don't create realtime filesystems with reflink enabled

From: Eric Sandeen <hidden>
Date: 2018-02-02 21:38:39

On 2/2/18 3:36 PM, Darrick J. Wong wrote:
From: Darrick J. Wong <redacted>

We don't support reflink on the realtime device, so don't let people
create such things.

Signed-off-by: Darrick J. Wong <redacted>
Reviewed-by: Eric Sandeen <redacted>
quoted hunk ↗ jump to hunk
---
 mkfs/xfs_mkfs.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 219b209..b20e3d6 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -2025,6 +2025,13 @@ _("cowextsize not supported without reflink support\n"));
 		usage();
 	}
 
+	if (cli->sb_feat.reflink && cli->xi->rtname) {
+		fprintf(stderr,
+_("reflink not supported with realtime devices\n"));
+		usage();
+		cli->sb_feat.reflink = false;
+	}
+
 	if (cli->sb_feat.rmapbt && cli->xi->rtname) {
 		fprintf(stderr,
 _("rmapbt not supported with realtime devices\n"));
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help