Re: [PATCH] mkfs: don't create realtime filesystems with reflink enabled
From: Eric Sandeen <hidden>
Date: 2018-02-01 01:09:17
On 1/31/18 6:47 PM, Darrick J. Wong wrote:
From: Darrick J. Wong <redacted> We don't support reflink on the realtime device, so don't let people create such things. Signed-off-by: Darrick J. Wong <redacted>
yup ... Reviewed-by: Eric Sandeen <redacted> (how long 'til we come up with the conflicts matrix for all this stuff? ;)
quoted hunk ↗ jump to hunk
--- mkfs/xfs_mkfs.c | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index f527476..07774ed 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c@@ -2025,6 +2025,13 @@ _("cowextsize not supported without reflink support\n")); usage(); } + if (cli->sb_feat.reflink && cli->xi->rtname) { + fprintf(stderr, +_("reflink not supported with realtime devices\n")); + usage(); + cli->sb_feat.reflink = false; + } + if (cli->sb_feat.rmapbt && cli->xi->rtname) { fprintf(stderr, _("rmapbt not supported with realtime devices\n")); --To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html