Thread (11 messages) 11 messages, 2 authors, 2018-01-26
STALE3070d

[PATCH 2/5] xfs/122: fix xfs header ordering problems

From: Darrick J. Wong <hidden>
Date: 2018-01-24 23:53:34
Also in: fstests
Subsystem: the rest · Maintainer: Linus Torvalds

From: Darrick J. Wong <redacted>

XFS headers are supposed to be included in a certain order so that
inline functions actually compile correctly.  For the most part the
shell feeds us the files in an order that works, but with the addition
of the xfs_dir2_dirblock_bytes function this doesn't always work now.
Therefore, explicitly #include the headers in the required order.

Signed-off-by: Darrick J. Wong <redacted>
---
 tests/xfs/122 |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/xfs/122 b/tests/xfs/122
index 671a77b..d836670 100755
--- a/tests/xfs/122
+++ b/tests/xfs/122
@@ -79,6 +79,11 @@ cat >$cprog <<EOF
 #define _GNU_SOURCE
 #include <stdio.h>
 EOF
+# Certain headers must be included in a certain order...
+for hdr in xfs.h xfs_types.h xfs_fs.h xfs_arch.h xfs_format.h; do
+	test -e "/usr/include/xfs/$hdr" && echo "#include <xfs/$hdr>" >> $cprog
+done
+# ...but be sure to pull in any new headers that might show up.
 for hdr in /usr/include/xfs/xfs*.h; do
 	echo "#include <$(echo "$hdr" | sed -e 's|/usr/include/||g')>" >> $cprog
 done
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help