Re: [PATCH] xfs: Capture state of the right inode in xfs_iflush_done
From: Darrick J. Wong <hidden>
Date: 2017-09-22 18:47:01
On Fri, Sep 22, 2017 at 01:35:55PM +0200, Carlos Maiolino wrote:
quoted hunk ↗ jump to hunk
My previous patch: d3a304b6292168b83b45d624784f973fdc1ca674 check for XFS_LI_FAILED flag xfs_iflush done, so the failed item can be properly resubmitted. In the loop scanning other inodes being completed, it should check the current item for the XFS_LI_FAILED, and not the initial one. The state of the initial inode is checked after the loop ends Kudos to Eric for catching this. Signed-off-by: Carlos Maiolino <redacted> --- fs/xfs/xfs_inode_item.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c index 6d0f74ec31e8..015e8ee793a3 100644 --- a/fs/xfs/xfs_inode_item.c +++ b/fs/xfs/xfs_inode_item.c@@ -745,7 +745,7 @@ xfs_iflush_done( */ iip = INODE_ITEM(blip); if ((iip->ili_logged && blip->li_lsn == iip->ili_flush_lsn) || - lip->li_flags & XFS_LI_FAILED) + blip->li_flags & XFS_LI_FAILED)
/me grumbles about the braces here, but will just fix that on the way in... Reviewed-by: Darrick J. Wong <redacted> --D
need_ail++; blip = next; -- 2.13.5 -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html