Re: [PATCH 4/7] xfs: Implement fallocate query support mode
From: Darrick J. Wong <hidden>
Date: 2017-09-18 20:48:43
Also in:
linux-fsdevel
Possibly related (same subject, not in this thread)
- 2017-09-19 · Re: [PATCH 4/7] xfs: Implement fallocate query support mode · OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
On Mon, Sep 18, 2017 at 05:52:24PM +0200, Lukas Czerner wrote:
quoted hunk ↗ jump to hunk
Return all fallcoate modes supported by xfs file system. Cc: linux-xfs@vger.kernel.org Signed-off-by: Lukas Czerner <redacted> --- fs/xfs/xfs_file.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index ebdd0bd..85e06c6 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c@@ -746,7 +746,8 @@ xfs_file_write_iter( #define XFS_FALLOC_FL_SUPPORTED \ (FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | \ FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE | \ - FALLOC_FL_INSERT_RANGE | FALLOC_FL_UNSHARE_RANGE) + FALLOC_FL_INSERT_RANGE | FALLOC_FL_UNSHARE_RANGE | \ + FALLOC_FL_QUERY_SUPPORT | FALLOC_FL_PREALLOC_RANGE) STATIC long xfs_file_fallocate(@@ -768,6 +769,9 @@ xfs_file_fallocate( if (mode & ~XFS_FALLOC_FL_SUPPORTED) return -EOPNOTSUPP; + if (mode & FALLOC_FL_QUERY_SUPPORT) + return XFS_FALLOC_FL_SUPPORTED;
Urk, manpage update describing the goals of the query interface and how
this is supposed to work is needed.
Are we required to return only the mode flags that would reasonably be
expected to work on this file, or the fs in general? Do we return zero
if the file is immutable (I guess the fd has to be O_RDONLY?) or if the
fs is readonly?
And like hch said, why not {f,}pathconf?
--D
+ xfs_ilock(ip, iolock); error = xfs_break_layouts(inode, &iolock); if (error) -- 2.7.5 -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html