Thread (13 messages) 13 messages, 3 authors, 2017-07-28

Re: [PATCH 1/5 v2] mkfs: replace variables with opts table: -b,d,s options

From: Eric Sandeen <hidden>
Date: 2017-07-28 02:18:17

On 7/27/17 11:39 AM, Luis R. Rodriguez wrote:
On Fri, Jul 21, 2017 at 02:34:48PM +0200, Jan Tulak wrote:
quoted
@@ -1609,6 +1593,7 @@ main(
 			break;
 		case 'b':
 			p = optarg;
+			uint64_t tmp;
Note:

An extra variable added, just so we can get the current value parsed
so we can then convert it to also set similar collateral variables.
Also, please don't declare variables in the middle of code like this,
we generally stick to C89 rules.

Thanks,
-Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help