Re: [PATCH v2] xfs_io: implement 'utimes' command
From: Eryu Guan <hidden>
Date: 2016-12-28 08:34:40
On Mon, Dec 19, 2016 at 06:51:26PM -0800, Deepa Dinamani wrote:
Add the utimes command to provide a way to utilize the futimens C library call. This is the interface to the utimensat system call, which updates the mtime and atime of a file. Signed-off-by: Deepa Dinamani <redacted> --- Changes since v1: * changed error return values * removed redundant roff formatting directive * removed unneeded argument count check include/input.h | 1 + io/Makefile | 2 +- io/init.c | 1 + io/io.h | 1 + io/utimes.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ libxcmd/input.c | 22 +++++++++++++++ man/man8/xfs_io.8 | 11 ++++++++ 7 files changed, 118 insertions(+), 1 deletion(-) create mode 100755 io/utimes.c mode change 100644 => 100755 libxcmd/input.c
Just one nit, I think c files should not have "x" in file modes. Thanks, Eryu