Thread (27 messages) 27 messages, 6 authors, 2017-01-04

Re: [PATCH 4/4] xfs: don't rely on ->total in xfs_alloc_space_available

From: Christoph Hellwig <hch@lst.de>
Date: 2016-12-14 19:38:04

On Wed, Dec 14, 2016 at 01:30:18PM -0500, Brian Foster wrote:
quoted
 	/* do we have enough contiguous free space for the allocation? */
+	alloc_len = args->minlen + (args->alignment - 1)+ args->minalignslop;
Whitespace nit, missing space:				^

Also, is the addition of braces intentional? I believe it is possible
for args->alignment == 0.
It's mostly for explaining the - 1 to the reader as it took me a while
to figure out what it was for.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help