Thread (4 messages) 4 messages, 4 authors, 2016-07-13

Re: [PATCH v2] xfs: abstract block export operations from nfsd layouts

From: Dave Chinner <david@fromorbit.com>
Date: 2016-07-13 23:23:29
Also in: linux-fsdevel, linux-nfs

On Wed, Jul 13, 2016 at 04:21:04PM -0400, J. Bruce Fields wrote:
On Sun, Jul 10, 2016 at 11:45:40AM +0200, Christoph Hellwig wrote:
quoted
On Fri, Jul 08, 2016 at 09:53:20AM -0400, Benjamin Coddington wrote:
quoted
Instead of creeping pnfs layout configuration into filesystems, move the
definition of block-based export operations under a more abstract
configuration.

Changes from v1:
	- dropped the first patch in the first posting
	- renamed the config to EXPORTFS_BLOCK_OPS from BLOCK_EXPORT_OPS
	- add an explicit default to no for EXPORTFS_BLOCK_OPS
	- add some help and menu text

Signed-off-by: Benjamin Coddington <redacted>
---
 fs/Kconfig          | 7 +++++++
 fs/nfsd/Kconfig     | 2 ++
 fs/xfs/Makefile     | 3 +--
 fs/xfs/xfs_export.c | 2 +-
 fs/xfs/xfs_pnfs.h   | 4 ++--
 5 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/fs/Kconfig b/fs/Kconfig
index 6725f59c18e6..ac6d3b36600c 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -66,6 +66,13 @@ config FS_POSIX_ACL
 config EXPORTFS
 	tristate
 
+config EXPORTFS_BLOCK_OPS
+	bool "Enable filesystem export operations for block IO"
+	default n
default n is the default, no need to add it.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks.  Applied, with that one "default n" line dropped.

An ACK from Dave might also help reassure Linus I'm not stepping on
anybody's toes.
Acked-by: Dave Chinner <david@fromorbit.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help