Re: [PATCH 2/3] XFS: Print error when xfs_ialloc_ag_select fails to find continuous free space.
From: Dave Chinner <david@fromorbit.com>
Date: 2012-09-11 22:48:09
Also in:
lkml
On Wed, Sep 12, 2012 at 03:43:23AM +0530, raghu.prabhu13@gmail.com wrote:
quoted hunk ↗ jump to hunk
From: Raghavendra D Prabhu <redacted> When xfs_ialloc_ag_select fails to find any AG with continuous free blocks required for inode allocation, printk the error in ratelimited manner. Signed-off-by: Raghavendra D Prabhu <redacted> --- fs/xfs/xfs_ialloc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/fs/xfs/xfs_ialloc.c b/fs/xfs/xfs_ialloc.c index 5aceb3f..e75a39d 100644 --- a/fs/xfs/xfs_ialloc.c +++ b/fs/xfs/xfs_ialloc.c@@ -539,8 +539,11 @@ nextag: if (agno >= agcount) agno = 0; if (agno == pagno) { - if (flags == 0) + if (flags == 0) { + xfs_err_ratelimited(mp, + "Out of continuous free blocks for inode allocation");
http://oss.sgi.com/archives/xfs/2012-06/msg00041.html <quote> Couple of things for all 3 patches. Firstly - 80 columns. We tend to keep the pformat string on a single line so it is easy to grep for like so: pr_err_once(mp, "Insufficient contiguous free space for inode allocation"); </quote> So, you need to change the error message to the one suggested, and follow 80-character width limits like the rest of the code. Also, I think the error message is better at the caller site, not in the function itself. i.e. if we get a NULLAGNUMBER returned, the caller decided whether to emit an error message or not. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs