Re: [PATCH 3/5] xfs: reduce ilock hold times in xfs_setattr_size
From: Dave Chinner <david@fromorbit.com>
Date: 2012-03-26 22:18:07
On Mon, Mar 26, 2012 at 05:14:24PM -0400, Christoph Hellwig wrote:
We do not need the ilock for most checks done in the beginning of xfs_setattr_size. Replace the long critical section before starting the transaction with a smaller one around xfs_zero_eof and an optional one inside xfs_qm_dqattach that isn't entered unless using quotas. While this isn't a big optimization for xfs_setattr_size itself it will allow pushing the ilock into xfs_zero_eof itself later. Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks sane to me. Reviewed-by: Dave Chinner <redacted> -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs