Thread (2 messages) 2 messages, 2 authors, 2012-02-17

Re: [PATCH] xfstests: more careful size grep in 256

From: Christoph Hellwig <hch@infradead.org>
Date: 2012-02-17 17:21:17

On Tue, Feb 14, 2012 at 10:26:01AM -0800, Eric Sandeen wrote:
Removing the "-F" flag in xfs_io changed stat output.

Before the change when -F was used, whether or not the file
was on xfs, it skipped the extra FSGEOM call.  Now that -F is 
removed, it calls FSGEOM if the file is on an xfs fs.  The "size" 
grep in test 256 was a bit too loose and matched 2 lines if the
FSGEOM output was present, breaking the test.

A more specific grep for stat.size fixes this.
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help