Re: [PATCH] xfs_io: deprecate the "-F" foreign flag
From: Eric Sandeen <hidden>
Date: 2012-02-03 16:10:47
From: Eric Sandeen <hidden>
Date: 2012-02-03 16:10:47
On 2/3/12 9:04 AM, Christoph Hellwig wrote:
On Thu, Feb 02, 2012 at 11:35:04AM -0600, Eric Sandeen wrote:quoted
There's no real reason to force the user to specify "-F" for non-xfs files, when we can just test for that after it's opened. * Remove the -F flag from usage() & man pages, but still accept it. * Set IO_FOREIGN when we open the file, if the fd tests as non-xfs.Looks good. We probably should kill the IO_FOREIGN eventually too, but let's do the user facing part first.
How would you want to handle non-xfs filesystems in the xfs-specific commands? Do the fd test each time?
Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks, I'll merge it. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs