Thread (40 messages) 40 messages, 3 authors, 2012-02-02

Re: [PATCH 12/12] repair: cleanup inode record macros

From: Mark Tinguely <hidden>
Date: 2012-01-12 17:05:34

On 01/11/12 05:30, Christoph Hellwig wrote:
ping?

On Fri, Dec 02, 2011 at 12:46:31PM -0500, Christoph Hellwig wrote:
quoted
Remove indirections in the inode record bit manipulation macros and flatten
them to a single level of inlines.  Also use a common IREC_MASK define
instead of duplicating it for every bitmask.


Signed-off-by: Christoph Hellwig<hch@lst.de>
Reviewed-by: Mark Tinguely <redacted>

The clean up looks good. I like the removal of the side effect that was 
in one of the ASSERT statement.

--Mark Tinguely

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help