Re: [PATCH] xfs: Fix missing xfs_iunlock() on error recovery path in xfs_readlink()
From: Ben Myers <hidden>
Date: 2012-01-11 19:13:33
On Wed, Jan 11, 2012 at 07:52:10PM +0100, Jan Kara wrote:
quoted hunk ↗ jump to hunk
Commit b52a360b forgot to call xfs_iunlock() when it detected corrupted symplink and bailed out. Fix it by jumping to 'out' instead of doing return. CC: stable@kernel.org CC: Carlos Maiolino <redacted> Signed-off-by: Jan Kara <jack@suse.cz> --- fs/xfs/xfs_vnodeops.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c index f2fea86..6156cd6 100644 --- a/fs/xfs/xfs_vnodeops.c +++ b/fs/xfs/xfs_vnodeops.c@@ -131,7 +131,8 @@ xfs_readlink( __func__, (unsigned long long) ip->i_ino, (long long) pathlen); ASSERT(0); - return XFS_ERROR(EFSCORRUPTED); + error = XFS_ERROR(EFSCORRUPTED); + goto out; }
Looks good to me. Reviewed-by: Ben Myers <redacted> _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs