Thread (11 messages) 11 messages, 3 authors, 2011-11-17

Re: [PATCH] change fallocate to xfs_io falloc

From: Ben Myers <hidden>
Date: 2011-11-17 20:50:18
Also in: linux-fsdevel

Hey Wu Bo,

On Thu, Nov 17, 2011 at 01:16:13PM +0800, WuBo wrote:
Thanks to Ben for pointing it that the fallocate maybe uninstall 
without checking it, and change fallocate to xfs_io as Christoph
suggested.

Signed-off-by: Wu Bo <redacted>
Nice!  It works great for me.  ;)

Reviewed-by: Ben Myers <redacted>

Thanks,
	Ben
quoted hunk ↗ jump to hunk
---
 274 |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/274 b/274
index b658004..bcf5a11 100755
--- a/274
+++ b/274
@@ -46,6 +46,7 @@ _cleanup()
 _supported_fs generic
 _supported_os IRIX Linux
 _require_scratch
+_require_xfs_io_falloc
 
 echo "------------------------------"
 echo "preallocation test"
@@ -67,7 +68,7 @@ then
 	exit
 fi
 
-fallocate -n -o 4K -l 1M test >/dev/null 2>&1
+$XFS_IO_PROG -F -f -c 'falloc 4096 1m' test >/dev/null
 if [ $? -ne 0 ]
 then
 	echo "fallocate file err"
-- 
1.7.3.1

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help