Re: xfs_repair: add printf format checking and fix the fallout
From: Alex Elder <hidden>
Date: 2011-09-19 22:40:02
On Sun, 2011-08-14 at 16:12 -0400, Christoph Hellwig wrote:
Add the gcc printf like attribute to the xfs_repair-internal logging helpers, and fix the massive fallout. A large part of it is dealing with the correct format for fixed size 64-bit types, but there were a lot of real bug in there, including some that lead to crashed when repairing certain corrupted filesystems on ARM based systems. Signed-off-by: Christoph Hellwig <hch@lst.de> Reported-by: Anisse Astier <redacted>
OK, I compiled in these environments: x86_64: clean build ia64: some new warnings, eliminated none of the old ones i686: still a few (non-printf) warnings, but none new If it weren't for the new warnings I would just say let's commit this and I can commit fixes for the remaining warnings separately. But instead I'll send you a patch privately for you to merge with what you've got. -Alex _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs