On Wed, 2011-08-24 at 02:04 -0400, Christoph Hellwig wrote:

Rather than passing the freeblock and freelist structure around, embed it

                          firstblock

into the bmalloca structure and remove it from the function parameters.

This also enables the minleft parameter to be set only once in
xfs_bmapi_write(), and the freelist cursor directly queried in
xfs_bmapi_allocate to clear it when the lowspace algorithm is activated.
    
    Signed-off-by: Dave Chinner [off-list ref]

A couple of comments:
- The struct xfs_bmalloca field "low" ought to be eliminated
  (or renamed "pad" or something), since it's now unused
  (->flist->xbf_low is used in its place).
- It might have been a bit simpler to review if using
  ->flist->xbf_low in place of ->low and ->minleft
  in place of minleft were done as separate, min-steps.

In any case, this looks good.

Reviewed-by: Alex Elder <redacted>



_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs